Allow API Gateway controller to get Namespaces #1092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Allow the Consul API Gateway controller to
get
,list
andwatch
namespaces. This enables the controller to validateHTTPRoutes
before attaching them to aGateway
that uses a namespace selector forallowedRoutes
.In this example, the
Gateway
only allows routes from a K8sNamespace
with labels matchingamAllowed: sure
:Before the controller attaches a route to this gateway, it needs to retrieve the namespace and see if the label selector matches, thus these new permissions.
How I've tested this PR:
Tested as part of analogous PR, hashicorp/consul-api-gateway#121.
How I expect reviewers to test this PR:
Follow testing described in hashicorp/consul-api-gateway#121.
Checklist: