Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consul connect environment variable injection fails when using different datacenter upstream #246

Closed
lkysow opened this issue Apr 15, 2020 · 1 comment
Closed

Consul connect environment variable injection fails when using different datacenter upstream #246

lkysow opened this issue Apr 15, 2020 · 1 comment
Labels
area/connect Related to Connect service mesh, e.g. injection type/bug Something isn't working

Comments

@lkysow
Copy link
Member

lkysow commented Apr 15, 2020

If setting an upstream annotation like:

    "consul.hashicorp.com/connect-service-upstreams": "static-server:1234:dc2"

The environment variables STATIC_SERVER_CONNECT_SERVICE_HOST=127.0.0.1, STATIC_SERVER_CONNECT_SERVICE_PORT=1234 aren't injected.

This is due to the logic here: https://github.com/hashicorp/consul-k8s/blob/master/connect-inject/container_env.go#L18-L20 which doesn't account for the colon-separated datacenter.
@lkysow lkysow added type/bug Something isn't working area/connect Related to Connect service mesh, e.g. injection labels Apr 15, 2020
@DerekStrickland DerekStrickland mentioned this issue Apr 23, 2020
Merged
@ishustava
Copy link
Contributor

Fixed by #250

ndhanushkodi pushed a commit to ndhanushkodi/consul-k8s that referenced this issue Jul 9, 2021
@ishustava
Merge pull request hashicorp#246 from hashicorp/acl-hook
223e904 
Add server-acl-init-cleanup job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/connect Related to Connect service mesh, e.g. injection type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkysow @ishustava