Address review comments and bugs.

- delete roles, rolebindings, service accounts by label
- use hack for setting namespace for helm kube client
- fallback to release name/namespace consul

cli/cmd/common/utils.go

@@ -2,10 +2,11 @@ package common
 
 import "strings"
 
-func PrefixLines(prefix, lines string) string {
-	var prefixedLines string
-	for _, l := range strings.Split(lines, "\n") {
-		prefixedLines += prefix + l + "\n"
+// Abort returns true if the raw input string is not equal to "y" or "yes".
+func Abort(raw string) bool {
+	confirmation := strings.TrimSuffix(raw, "\n")
+	if !(strings.ToLower(confirmation) == "y" || strings.ToLower(confirmation) == "yes") {
+		return true
 	}
-	return strings.TrimSuffix(prefixedLines, "\n")
+	return false
 }

cli/cmd/install/install.go

@@ -170,15 +170,16 @@ func (c *Command) init() {
 func (c *Command) Run(args []string) int {
 	c.once.Do(c.init)
 
+	// The logger is initialized in main with the name cli. Here, we reset the name to install so log lines would be prefixed with install.
+	c.Log.ResetNamed("install")
+
 	defer func() {
 		if err := c.Close(); err != nil {
-			c.UI.Output(err.Error())
+			c.Log.Error(err.Error())
+			os.Exit(1)
 		}
 	}()
 
-	// The logger is initialized in main with the name cli. Here, we reset the name to install so log lines would be prefixed with install.
-	c.Log.ResetNamed("install")
-
 	if err := c.validateFlags(args); err != nil {
 		c.UI.Output(err.Error())
 		return 1
@@ -290,8 +291,7 @@ func (c *Command) Run(args []string) int {
 			c.UI.Output(err.Error(), terminal.WithErrorStyle())
 			return 1
 		}
-		confirmation = strings.TrimSuffix(confirmation, "\n")
-		if !(strings.ToLower(confirmation) == "y" || strings.ToLower(confirmation) == "yes") {
+		if common.Abort(confirmation) {
 			c.UI.Output("Install aborted. To learn how to customize your installation, run:\nconsul-k8s install --help", terminal.WithInfoStyle())
 			return 1
 		}