Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Update CRDs with updated formatting and mesh config #992

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Jun 17, 2021

How I've tested this PR: Acceptance tests

How I expect reviewers to test this PR: 👀

Checklist:

  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@thisisnotashwin thisisnotashwin requested review from lkysow, a team, kschoche and ishustava and removed request for a team and kschoche June 17, 2021 15:20
@thisisnotashwin thisisnotashwin force-pushed the ashwin/dialed-directly branch 3 times, most recently from d226b66 to 7541309 Compare June 17, 2021 16:58
@ishustava
Copy link
Contributor

Looks like there was a failure in acceptance tests due to a nil pointer panic in the consul agent:

2021-06-17T17:12:46.545Z [INFO]  agent: Consul agent running!
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x1e01bf9]

goroutine 146 [running]:
github.com/hashicorp/consul/agent/proxycfg.(*state).handleUpdateConnectProxy(0xc000ba45a0, 0x344e9d2, 0x13, 0x30dac40, 0xc000632640, 0x0, 0x0, 0x25, 0x0, 0x0, ...)
	/home/circleci/project/consul-enterprise/agent/proxycfg/state.go:867 +0x13f9
github.com/hashicorp/consul/agent/proxycfg.(*state).handleUpdate(0xc000ba45a0, 0x344e9d2, 0x13, 0x30dac40, 0xc000632640, 0x0, 0x0, 0x25, 0x0, 0x0, ...)
	/home/circleci/project/consul-enterprise/agent/proxycfg/state.go:735 +0x1bd
github.com/hashicorp/consul/agent/proxycfg.(*state).run(0xc000ba45a0, 0xc000990380)
	/home/circleci/project/consul-enterprise/agent/proxycfg/state.go:643 +0x2c5
created by github.com/hashicorp/consul/agent/proxycfg.(*state).Watch
	/home/circleci/project/consul-enterprise/agent/proxycfg/state.go:195 +0x198

@thisisnotashwin
Copy link
Contributor Author

Looks like there was a failure in acceptance tests due to a nil pointer panic in the consul agent:

2021-06-17T17:12:46.545Z [INFO]  agent: Consul agent running!
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x1e01bf9]

goroutine 146 [running]:
github.com/hashicorp/consul/agent/proxycfg.(*state).handleUpdateConnectProxy(0xc000ba45a0, 0x344e9d2, 0x13, 0x30dac40, 0xc000632640, 0x0, 0x0, 0x25, 0x0, 0x0, ...)
	/home/circleci/project/consul-enterprise/agent/proxycfg/state.go:867 +0x13f9
github.com/hashicorp/consul/agent/proxycfg.(*state).handleUpdate(0xc000ba45a0, 0x344e9d2, 0x13, 0x30dac40, 0xc000632640, 0x0, 0x0, 0x25, 0x0, 0x0, ...)
	/home/circleci/project/consul-enterprise/agent/proxycfg/state.go:735 +0x1bd
github.com/hashicorp/consul/agent/proxycfg.(*state).run(0xc000ba45a0, 0xc000990380)
	/home/circleci/project/consul-enterprise/agent/proxycfg/state.go:643 +0x2c5
created by github.com/hashicorp/consul/agent/proxycfg.(*state).Watch
	/home/circleci/project/consul-enterprise/agent/proxycfg/state.go:195 +0x198

Yup! Looks like there was a bug in consul where we were missing a nil check. This is being addressed now by hashicorp/consul#10423

@thisisnotashwin thisisnotashwin force-pushed the ashwin/dialed-directly branch 2 times, most recently from e00e52a to fe12ed5 Compare June 17, 2021 18:48
@thisisnotashwin thisisnotashwin merged commit 3260703 into master Jun 17, 2021
@thisisnotashwin thisisnotashwin deleted the ashwin/dialed-directly branch June 17, 2021 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants