Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add mesh resource to consul-helm #941

Merged
merged 1 commit into from
May 6, 2021
Merged

Add mesh resource to consul-helm #941

merged 1 commit into from
May 6, 2021

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented May 4, 2021

Changes proposed in this PR:

  • Add mesh resource to consul

How I've tested this PR:

How I expect reviewers to test this PR: Code review

Checklist:

  • Bats tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@thisisnotashwin thisisnotashwin added enhancement New feature or request theme/crds labels May 4, 2021
@thisisnotashwin thisisnotashwin requested review from ishustava, a team and ndhanushkodi and removed request for a team May 4, 2021 18:15
@thisisnotashwin thisisnotashwin force-pushed the mesh-resource branch 2 times, most recently from af0ed93 to afec8ec Compare May 4, 2021 19:43
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

@thisisnotashwin thisisnotashwin force-pushed the mesh-resource branch 4 times, most recently from f594b0a to df5cfcd Compare May 5, 2021 14:21
@thisisnotashwin thisisnotashwin merged commit f70823d into master May 6, 2021
@thisisnotashwin thisisnotashwin deleted the mesh-resource branch May 6, 2021 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request theme/crds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants