Remove -disable-host-node-id=false flag

[lkysow]

Don't set -disable-host-node-id=false on Consul Clients because it causes Clients to
not be able to join the cluster on certain hypervisor or Kind setups. This flag was
added in 0.30.0 to stop Consul logging an error when a Client pod was force deleted
but this error does not affect the pod restarting so removing the flag will have
no real effect.

Fixes #901

Checklist:

• Bats tests added
• CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

[ishustava]

🙏

[ndhanushkodi]

🎉

[ilhaan]

Kind and other hypervisor types that you mentioned need to set -disable-host-node-id to true in order to get Consul Clients working correctly (refer to issues: 9467 and 848).

As per Consul docs here, -disable-host-node-id is false by default, which is what #901 had set in values.yaml and templates/client-daemonset.yaml.

The changelog for this PR states:

This flag was added in 0.30.0 to stop Consul logging an error when a Client pod was force deleted but this error does not affect the pod restarting so removing the flag will have no real effect.

That is incorrect. This was introduced in #901 to allow the override of disableHostNodeID to true for Kind and other hypervisor types (such as OpenNebula 5.12 launched LXD containers as mentioned here)

[lkysow]

Hi, please see my comment here #848 (comment).

As per Consul docs here, -disable-host-node-id is false by default

The docs are a bit confusing, the relevant section is:

This defaults to false in Consul prior to version 0.8.5 and in 0.8.5 and later defaults to true

I'm assuming you're running Consul version > 0.8.5 so the default is true.

[ilhaan]

I am running Consul version > 0.8.5. Thanks for the clarification!