This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
remove healthcheck and cleanup controller flags #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschoche
requested review from
ndhanushkodi and
thisisnotashwin
and removed request for
a team
kschoche
commented
Apr 7, 2021
| } | ||
|
|
||
| @test "client/ConfigMap: check_update_interval is set when health checks enabled" { | ||
| @test "client/ConfigMap: check_update_interval is set when connect is enabled" { |
There was a problem hiding this comment.
Now that health checks are "always on" we will do this anytime connect is enabled.
kschoche
commented
Apr 8, 2021
kschoche
commented
Apr 8, 2021
update ci to point to latest feature-tproxy build
kschoche
force-pushed
the
tproxy-remove-cleanup-hc-controller-flags
branch
from
0f42db9 to
ea056a4
Compare
ndhanushkodi
approved these changes
Apr 12, 2021
| @@ -93,8 +93,8 @@ func TestConnectInject(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // Test the cleanup controller that cleans up force-killed pods. | |||
| func TestConnectInject_CleanupController(t *testing.T) { | |||
| // Test the endpoints controller cleans up force-killed pods. | |||
There was a problem hiding this comment.
Nice! Are there any healthchecks-specific acceptance tests? I didn't see any when looking but thought I'd ask.
There was a problem hiding this comment.
+1. The health check test is part of the standard connect test (there are some extra assertions about the health checks).
ishustava
approved these changes
Apr 13, 2021
| @@ -93,8 +93,8 @@ func TestConnectInject(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // Test the cleanup controller that cleans up force-killed pods. | |||
| func TestConnectInject_CleanupController(t *testing.T) { | |||
| // Test the endpoints controller cleans up force-killed pods. | |||
There was a problem hiding this comment.
+1. The health check test is part of the standard connect test (there are some extra assertions about the health checks).
thisisnotashwin
pushed a commit
that referenced
this pull request
Apr 15, 2021
* remove healthcheck and cleanup controller flags
ishustava
pushed a commit
that referenced
this pull request
Apr 16, 2021
* remove healthcheck and cleanup controller flags
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
bats tests, these flags have defaults in consul-k8s so not passing them should still pass.
How I expect reviewers to test this PR:
bats tests
Checklist: