Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Upgrade CRD versions to v1 #883

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Upgrade CRD versions to v1 #883

merged 1 commit into from
Mar 25, 2021

Conversation

thisisnotashwin
Copy link

@thisisnotashwin thisisnotashwin commented Mar 24, 2021

Changes proposed in this PR:

  • Update CRD versions from v1beta1 to v1
  • The new version of controller-runtime requires the controller to have CRUD access on coordination.k8s.io/lease.
    The above resource was promoted to v1 in Kubernetes 1.14.1

How I've tested this PR: Acceptance tests

How I expect reviewers to test this PR: Code Review

Checklist:

  • Bats tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@thisisnotashwin thisisnotashwin force-pushed the upgrade-crd-version branch 3 times, most recently from b34dd44 to a71ca02 Compare March 24, 2021 21:29
@thisisnotashwin thisisnotashwin requested review from lkysow, a team and ishustava and removed request for a team March 24, 2021 21:30
@thisisnotashwin thisisnotashwin marked this pull request as ready for review March 24, 2021 21:30
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested out an upgrade and messed around with the crds and it worked without issue

@@ -144,7 +144,7 @@ jobs:
-kubecontext="kind-dc1" \
-secondary-kubecontext="kind-dc2" \
-debug-directory="$TEST_RESULTS/debug" \
-consul-k8s-image=docker.mirror.hashicorp.services/hashicorpdev/consul-k8s:latest
-consul-k8s-image=ashwinvenkatesh/consul-k8s@sha256:db090be0f57dbb69ff63a939175a8d01fa276927aaa49b67a85db56301e50a58
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder

Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's also update the readme to say that we're now requiring 1.16+

@thisisnotashwin thisisnotashwin merged commit f17d6f6 into master Mar 25, 2021
@thisisnotashwin thisisnotashwin deleted the upgrade-crd-version branch March 25, 2021 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants