This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Companion PR to Add LastSyncedTime field on CRDs consul-k8s#448
How I've tested this PR:
ashwinvenkatesh/consul-k8s@sha256:8f2d59278f4b8deca8eaeb643a3e6143684e4c37a3e03c051781a1c42a8d70d4
for consul-k8skubectl get resource
now displays a column Last Synced At with time since the successful sync.How I expect reviewers to test this PR:
Edit the config with a "failing" spec and save it. The Last Synced time should now not update as the sync will be unsuccessful.
Checklist: