This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Deal with the sprig library using int for sub and div values #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a clever way to do this and good job catching this. Awesome job on the tests too 😮 I'll defer to @adilyse to hit the button and review 😄 |
adilyse
suggested changes
Dec 5, 2018
There was a problem hiding this comment.
Thanks for the PR! This is a good fix with very thorough tests.
I'm working on keeping the tests titles understandable in isolation, so I really prefer explicitly mentioning that we're setting replicas vs. using n which could mean any number of things. Hopefully it's quick to accept the suggestions and we can get this merged!
|
@adilyse All updated |
adilyse
approved these changes
Dec 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
http://masterminds.github.io/sprig/math.html
Functions within the sprig library utilise integer values causing disruption budget to not provide usable values.