Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add controller.aclToken #783

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Add controller.aclToken #783

merged 2 commits into from
Jan 26, 2021

Conversation

hamishforbes
Copy link
Contributor

Adds optional controller.aclToken.
Provide a pre-existing kubernetes secret with an ACL token for the controller deployment

Closes #778

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a couple suggestions.

values.yaml Outdated Show resolved Hide resolved
values.yaml Show resolved Hide resolved
values.yaml Show resolved Hide resolved
@hamishforbes
Copy link
Contributor Author

Thanks! I'm sure you can tell, I largely just copied the syncCatalog implementation, but that all makes sense.

@lkysow
Copy link
Member

lkysow commented Jan 25, 2021

I'm sure you can tell, I largely just copied the syncCatalog implementation, but that all makes sense.

Yeah for sure, we should update that part too but may as well get some docs improvements here while we're in here.

@lkysow lkysow merged commit f546662 into hashicorp:master Jan 26, 2021
@lkysow lkysow mentioned this pull request Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify an ACL token for the controller deployment
3 participants