Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add ability to set extra labels on client pods #612

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

hamishforbes
Copy link
Contributor

Same as #553 but for the client daemonset pods

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 22, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkysow lkysow added area/chart-only Related to changes that simply require yaml chart changes, e.g. exposing a new field enhancement New feature or request labels Oct 8, 2020
@hamishforbes
Copy link
Contributor Author

Any chance of this being merged now? It's been approved for quite a while

@ishustava
Copy link
Contributor

Hey @hamishforbes, sorry for the delay!

I think this is good to go if you have a moment to fix the conflicts.

@hamishforbes
Copy link
Contributor Author

Sure!
Rebased and added type hint to the comment

Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution!

@ishustava ishustava merged commit c93b5db into hashicorp:master Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/chart-only Related to changes that simply require yaml chart changes, e.g. exposing a new field enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants