This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Annotate deployments with hashed extraconfig #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
requested review from
lkysow,
a team and
ishustava
and removed request for
a team
ishustava
approved these changes
Jul 24, 2020
|
Oh, I think we need to add a changelog entry |
thisisnotashwin
force-pushed
the
annotateConfig
branch
from
86ce70c to
65a0941
Compare
lkysow
reviewed
Jul 24, 2020
| @@ -1,5 +1,11 @@ | |||
| ## Unreleased | |||
|
|
|||
| IMPROVEMENTS: | |||
There was a problem hiding this comment.
I think this might need to be listed as a breaking change too? Since doing a full restart of all the clients and servers can be destructive.
- When the extra config for a client or server is updated, it updates the underlying configMap but has no way of informing the server statefulSet or client daemonSet of the update.With this PR, the values for server.extraConfig & client.extraConfig are saved as annotations on the server statefulSet spec and client daemonsetSpec respectfully. If a user updates the extraConfig and performs a `helm upgrade`, it will force a reconcile of the server and client pods (depending on what changed) and will keep them updated with the latest config. Signed-off-by: Ashwin Venkatesh <[email protected]>
thisisnotashwin
force-pushed
the
annotateConfig
branch
from
65a0941 to
5a184df
Compare
lkysow
reviewed
Jul 24, 2020
lkysow
approved these changes
Jul 24, 2020
Co-authored-by: Luke Kysow <[email protected]>
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the extra config for a client or server is updated, it updates the underlying configMap but has no way of informing the server statefulSet or client daemonSet of the update.With this PR, the values for server.extraConfig & client.extraConfig are saved as annotations on the server statefulSet spec and client daemonsetSpec respectfully. If a user updates the extraConfig and performs a
helm upgrade, it will force a reconcile of the server and client pods (depending on what changed) and will keep them updated with the latest config.Signed-off-by: Ashwin Venkatesh [email protected]
Testing:
• Install consul using
helm installwith some values file• Update
sever.extraConfigand perform ahelm upgradewith the file• Observe
kubectl get pods. The existing server pod will terminate and a new one will spin up with the updated config. You can compare the value of the annotation "consul.hashicorp.com/config-checksum" before and after the upgrade to see it change.• Update
client.extraConfigand perform ahelm upgradewith the file• Observe
kubectl get pods. The existing client pod will terminate and a new one will spin up with the updated config. You can compare the value of the annotation "consul.hashicorp.com/config-checksum" before and after the upgrade to see it change.• Be in awe.