Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Deprecate setting resources as string. #465

Merged
merged 1 commit into from
May 28, 2020
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented May 21, 2020

Deprecate setting:

client:
    resources: |
      requests:
        memory: "128Mi"
        cpu: "250m"
      limits:
        memory: "256Mi"
        cpu: "500m"

for

client:
    resources:
      requests:
        memory: "128Mi"
        cpu: "250m"
      limits:
        memory: "256Mi"
        cpu: "500m"

Applies to server, client and mesh gateway resources. Lays groundwork for upcoming resource settings.

Related to the work done on the vault chart in hashicorp/vault-helm#272

@lkysow lkysow requested a review from a team May 21, 2020 20:03
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

values.yaml Show resolved Hide resolved
@lkysow lkysow force-pushed the resources-deprecation branch from ebf6184 to 488c3ef Compare May 28, 2020 17:55
@lkysow lkysow force-pushed the resources-deprecation branch from 488c3ef to f3044d1 Compare May 28, 2020 17:57
@lkysow lkysow merged commit 627c7ae into master May 28, 2020
@lkysow lkysow deleted the resources-deprecation branch May 28, 2020 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants