This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Restrict permissions for the server-acl-init job #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the server-acl-init job takes server DNS names as input, we don't need permissions to list pods and get statefulsets. Additionally, only set one of connectInject.enabled to true in the generated config for HCS since we don't recommend enabling both connectInject and syncCatalog.
ishustava
added
area/acls
lkysow
approved these changes
May 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the server-acl-init command takes server DNS names as input, we don't need permissions to list pods and get statefulsets.
Additionally, only set one of
connectInject.enabledto true in the generated config for HCS since we don't recommend enabling bothconnectInjectandsyncCatalog.