This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Support terminating gateways #452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
reviewed
May 11, 2020
| @@ -0,0 +1,324 @@ | |||
| {{- if .Values.terminatingGateways.enabled }} | |||
There was a problem hiding this comment.
Can we use len(.Values.terminatingGateways.gateways) instead?
There was a problem hiding this comment.
I was going to have one gateway defined automatically in the gateways field as an example. Then someone could enable gateways and get a gateway without doing any extra work. It should also simplify the explanation of required gateway fields-- though I suppose we'll still have to explain the extraVolumes field so maybe that's a wash.
adilyse
force-pushed
the
terminating-gateways
branch
from
3d05c92 to
595bb6a
Compare
This creates all of the necessary templates to support terminating gateways in the helm chart. Using `terminatingGateways.defaults` and `terminatingGateways.gateways`, it's possible to define multiple gateways. Names must be provided for each and they must be unique. Any gateway-specific values will override the default value with the exception of annotations. Annotations will apply both the defaults and gateway-specific annotations. TODO: Add tests.
adilyse
force-pushed
the
terminating-gateways
branch
from
595bb6a to
92e8c70
Compare
adilyse
changed the title
adilyse
added
area/gateways
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates all of the necessary templates to support terminating
gateways in the helm chart. Using
terminatingGateways.defaultsandterminatingGateways.gateways, it's possible to define multiplegateways. Names must be provided for each and they must be unique.
Any gateway-specific values will override the default value with the
exception of annotations. Annotations will apply both the defaults
and gateway-specific annotations.
TODO: Add tests.