This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Support ACL replication. #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
commented
Mar 5, 2020
templates/server-acl-init-job.yaml
Outdated
| {{- end }} | ||
| {{- if (and .Values.global.acls.replicationToken.secretName .Values.global.acls.replicationToken.secretKey) }} | ||
| -enable-acl-replication=true \ | ||
| -datacenter={{ .Values.global.datacenter }} \ |
There was a problem hiding this comment.
This flag is only needed if we're in replication mode. I put it here to make the helm chart backwards compatible with older versions of consul-k8s that don't have this flag. For single-dc users, this flag isn't needed.
lkysow
added
area/multi-dc
ishustava
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
Luke, this looks good. A couple of thoughts:
- The datacenter flag could be retrieved from the server by the ACL bootstrapping job itself. This is optional though and definitely should not block the merge.
- When it comes to using the replication token to determine if this is the secondary datacenter, I like it. I personally have a bias towards having less configuration options.
- Right now the
bootstrapACLsand theacl.*properties don't interact. I know you've mentioned that this is something you're thinking to change in the future PR, but I thought it's worth noting it here so we don't forget.
|
Updated to remove |
|
Oh, also changed to use the |
ishustava
approved these changes
Mar 14, 2020
There was a problem hiding this comment.
Looks good! I've tested this PR in combination with hashicorp/consul-k8s#226; everything worked great!
Suport creating an ACL replication token (for primary dcs) and referencing a pre-created ACL replication token (for secondary dcs).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support creating an ACL replication token (for primary dcs) via
global.acls.createReplicationTokenandreferencing a pre-created ACL replication token (for secondary dcs) via
global.acls.replicationToken.One thing to review here is that we're using the existence of
global.acls.replicationTokento determine whether we set other config flags that are required for replication. We could have had a separate setting, e.g.global.acls.enableReplication.