Update test-runner.yaml

[tehmoon]

Add namespace to the tester and force restart it if failing.

[hashicorp-cla]

All committers have signed the CLA.

[ishustava]

Hey @tehmoon,

Thanks for this PR! Adding a namespace makes sense, but I'm curious why you are also changing the restartPolicy? This test is meant to run after all pods are in the ready state and provide quick feedback on the state of the cluster. Changing the restart policy means that helm test could hang up to 5min (Kubernetes default timeout for restarts).

[tehmoon]

Hi @ishustava.
Thank you for following up!

I also changed the restartPolicy because using this chart with helm template and applying the result to kubernetes directly, I saw that the tester pod was actually being scheduled right away, before the consul pods, making in fail right away.

If that blocks your pipeline, let me know and I'll remove it.

[lkysow]

If using helm template, we recommend running with ``` tests: enabled: false ``` We added that just for helm template.

…

On Tue, Dec 24, 2019, 6:41 AM tehmoon ***@***.***> wrote: Hi @ishustava <https://github.com/ishustava>. Thank you for following up! I also changed the restartPolicy because using this chart with helm template and applying the result to kubernetes directly, I saw that the tester pod was actually being scheduled right away, before the consul pods, making in fail right away. If that blocks your pipeline, let me know and I'll remove it. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#320?email_source=notifications&email_token=AAH4RPPFNT4RUURRFGKEVYTQ2H7OTA5CNFSM4J6Y4DSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHTEZAY#issuecomment-568740995>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH4RPLRIRIH4F6HM26QWHLQ2H7OTANCNFSM4J6Y4DSA> .

[tehmoon]

Hi @lkysow,

Yes that's what I'm doing but if one wants to starts the tests, it does not work if using a namespace.
Alternatively, it works if kustomize sets the namespace on top of helm3 template.

[ishustava]

Hey @tehmoon, if you don't mind removing the restartPolicy change (based on what @lkysow said), I can approve your PR. The namespace change looks good.

[tehmoon]

@ishustava Done!! Thank you so much for the follow up.

[ishustava]

🎉

[ishustava]

Thank you for making the change @tehmoon and for the PR!