Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Consul agent registers node with the name of the pod #14

Closed
mmisztal1980 opened this issue Sep 30, 2018 · 3 comments · Fixed by #15
Closed

Consul agent registers node with the name of the pod #14

mmisztal1980 opened this issue Sep 30, 2018 · 3 comments · Fixed by #15
Labels
enhancement New feature or request

Comments

@mmisztal1980
Copy link
Contributor

When starting agent instances, the agents use the hostnames of the pods consul-{random} to register as nodes. IMHO this isn't desired and creates confusion for the operator of the consul cluster, b/c it's impossible to tell which node represents which physical k8s node.

@mmisztal1980
Copy link
Contributor Author

@mitchellh please have a look if my issue is valid and the proposed solution is satisfactory.
Best regards

@mitchellh mitchellh added enhancement New feature or request good first issue labels Oct 3, 2018
@mmisztal1980
Copy link
Contributor Author

@mitchellh did you guys get a chance to review the PR?

@mitchellh
Copy link
Contributor

We're going to take a look soon. I just want to verify that this doesn't cause any issues with the server agents since they run alongside the client agents in K8S (due to daemonsets not respecting affinities). I don't think so since I think they set their node name to something else, but just want to be sure!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants