Add support for DeviceAuthURL and a Provider.Config() API #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrDaveD
requested review from
jimlambrt,
austingebauer and
hcjulz
as code owners
This was referenced Aug 14, 2024
|
@DrDaveD I'll try to get you some review feedback by end of this week; baring unforeseen circumstances. |
|
@jimlambrt I suppose those unforeseen circumstances occurred? Can you get that review feedback soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go-oidc library added support for
DeviceAuthURLin coreos/go-oidc#365. This adds it also to the cap library and also makes aProviderConfigstructure available through a new API callProvider.Config()so an application like the one added in hashicorp/vault-plugin-auth-jwt#131 that needs those URLs does not need to discover them itself. Note that it does not include JWKSURL because that is not available through the go-oidc API.At the same time, this adds
DeviceAuthURLto theDiscoveryInfoAPI.