Add worker tagging #862
Merged
Add worker tagging #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
api
api/targets
core
core/db
core/gen
core/proto
core/servers
core/session
core/target
labels
mgaffney
requested changes
Jan 20, 2021
jimlambrt
requested changes
Jan 21, 2021
internal/db/schema/migrations/postgres/dev/70_server_tags_migrations.down.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Gaffney <[email protected]>
Co-authored-by: Michael Gaffney <[email protected]>
mgaffney
previously approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to add tags to workers and use a worker filter in targets to pick which workers are allowed to handle a session.
NOTE: Dependent on the migrations PR so can't be merged before then, but can be reviewed. I'll have to adjust the SQL logic to correspond to that when it's merged.
NOTE 2: Docs will come later, as we're working out which docs should go on which site.
NOTE 3: For reviewing I recommend enabling the ignore-whitespace option.