Organize DB Schema Migration Code and DB Init Checks #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…command is created. Replaced additional context.TODOs with context.Backgrounds.
jimlambrt
approved these changes
Jan 15, 2021
mgaffney
requested changes
Jan 15, 2021
internal/db/schema/schema.go
Outdated
| return false, err | ||
| } | ||
| if st.Dirty { | ||
| return false, fmt.Errorf("The passed in database has had a failed migration applied to it.") |
mgaffney
previously approved these changes
Jan 16, 2021
| // https://www.postgresql.org/docs/9.6/static/explicit-locking.html#ADVISORY-LOCKS | ||
| func (p *Postgres) TrySharedLock(ctx context.Context) error { | ||
| const op = "postgres.(Postgres).TrySharedLock" | ||
| r := p.conn.QueryRowContext(ctx, "SELECT pg_try_advisory_lock_shared($1)", schemaAccessLockId) |
There was a problem hiding this comment.
Previous comments are not showing up for some reason.
Me:
Why is there no equivalent unlock method for this (
select pg_advisory_unlock_shared($1))?
Todd:
Just because we do not have a use for it yet.
Shouldn't we be releasing the lock by calling select pg_advisory_unlock_shared($1)? Or are we just letting Postgres do the cleanup when the connection closes? If it is the latter, are there any dangers on relying on that?
mgaffney
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganizes the code which applies schema changes in Boundary and sets up the ability (in future PRs) to migrate to newer versions of the database schema when needed.
Added checks when
boundary server -configstarts a controller to ensure that the database was initialized correctly. Also checks inboundary database init -configto ensure the database is in a state that can be initialized.Fixes #805