Add kube connect subcommand
#816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malnick
reviewed
Dec 14, 2020
internal/cmd/commands.go
Outdated
| }, nil | ||
| }, | ||
| "connect rdp": func() (cli.Command, error) { | ||
| "connect k8s": func() (cli.Command, error) { |
There was a problem hiding this comment.
Wondering if the auto complete will be confusing with both commands that start with k? You'll get two possible sub commands, and if you're unfamiliar, may not know they do the same thing. Wondering if you think we should start with one only and grow to two once people start using it?
There was a problem hiding this comment.
Will scope to just kube for now. Many people prefer k8s but kube matches kubectl -- it's not k8sctl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.