Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not print info in output that could be JSON or YAML format #799

Merged
merged 2 commits into from
Nov 20, 2020
Merged

fix: do not print info in output that could be JSON or YAML format #799

merged 2 commits into from
Nov 20, 2020

Conversation

malnick
Copy link
Collaborator

@malnick malnick commented Nov 20, 2020

Fixes #791

There were two avenues I considered for this:

  1. Check c.flagFormat and print the info level statement if the value is not json or yaml
  2. Remove the info level output all together

I went with #2 because it was more simple, but I'm open to other possible paths too.

@malnick malnick requested a review from jefferai November 20, 2020 00:38
@github-actions github-actions bot added the core label Nov 20, 2020
jefferai
jefferai previously approved these changes Nov 20, 2020
View reviewed changes
@malnick malnick added this to the 0.1.3 milestone Nov 20, 2020
@malnick malnick merged commit af2d9df into main Nov 20, 2020
@malnick malnick deleted the iss-791 branch November 20, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai left review comments

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
0.1.3
Development

Successfully merging this pull request may close these issues.

JSON output invalid due to errors on stdout
2 participants
@malnick @jefferai