feat: add official Dockerfile for Boundary #755
Conversation
docker/Dockerfile
Outdated
| hkp://p80.pool.sks-keyservers.net:80 \ | ||
| hkp://keyserver.ubuntu.com:80 \ | ||
| hkp://pgp.mit.edu:80 \ | ||
| ; do \ |
There was a problem hiding this comment.
I would probably just hardcode the key in this repo somewhere and import it, rather than be exposed to the internet to download it, since its fingerprint is already hardcoded. Not blocking though.
There was a problem hiding this comment.
Totally hear that, I was torn between having consistency between our other Dockerfiles though.
scripts/uigen.sh
Outdated
| @@ -13,8 +13,7 @@ fi | |||
| ( | |||
| cd "$UI_CLONE_DIR" | |||
| if ! docker-compose -f docker-compose-embedding.yml run build; then | |||
| echo "==> UI build failed." | |||
| exit 1 | |||
| yarn install && yarn build | |||
There was a problem hiding this comment.
I can't see this script referenced anywhere else in the PR, it seems like a reasonable fallback though. Note that for release builds, the UI compilation is defined here, in order to not rely on Docker. We should probably have that call this script.
There was a problem hiding this comment.
Yeah, I had some code that was building off HEAD and wanted this to avoid docker-in-docker. Then it turned out to be a nice fallback anyways for some other pipelines I was on.
docker/config.hcl
Outdated
| description = "A controller for a demo!" | ||
|
|
||
| database { | ||
| url = "postgresql://postgres:[email protected]:5432/postgres?sslmode=disable" |
There was a problem hiding this comment.
Going to update this with the env:// pattern to allow easy overrides from -e flag in docker run.
docker/Dockerfile
Outdated
| @@ -0,0 +1,46 @@ | |||
| FROM alpine:3.10 | |||
There was a problem hiding this comment.
All we need to do is update this to docker.mirror.hashicorp.services/alpine:3.10 to avoid the dockerhub rate limits.
No description provided.