Allow authorize-session to be invoked with target name #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
api
api/targets
core
core/auth
core/gen
core/proto
core/servers
core/target
labels
jimlambrt
previously approved these changes
Oct 21, 2020
There was a problem hiding this comment.
Looks great (needs tests). The only thing that I got stuck on was the name "RoundTripValue" since it's not really round tripped to and from authResult(), but rather just a special return value in the result set.... it's a minor point. Maybe something like "LookupValue"?
This was referenced Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a combination of target name and either scope ID or scope name. Sets the stage for potential future relaxations around name as well.