internal/daemon/worker: speed up multi-worker tests #5370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of sleeping, we can poll for the desired state. Also, run shutdowns in parallel.
irenarindos
approved these changes
Dec 17, 2024
moduli
reviewed
Dec 17, 2024
| require.Eventually( | ||
| func() bool { | ||
| t.Log("Checking worker status") | ||
| workers, err := serversRepo.ListWorkers(controllerContext, []string{"global"}) |
There was a problem hiding this comment.
Question: Is NewTestMultihopWorkers ever called by parallel tests? Could this impact the output of ListWorkers?
There was a problem hiding this comment.
Not as long as each test is using it's own controller, which I think we have to assume the parallel tests are doing.
moduli
approved these changes
Dec 17, 2024
johanbrandhorst
added a commit
that referenced
this pull request
Dec 19, 2024
Unfortunately, this started causing the enterprise tests to break in an unexpected way. Reverting to spend some more time testing the changes.
johanbrandhorst
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sleeping, we can poll for the desired state. Also, run shutdowns in parallel. This mostly affects the enterprise tests that start multiple workers.