Backport of internal/event: avoid reusing canceled context into release/0.18.x #5310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-boundary
force-pushed
the
backport/jbrandhorst-fix-startup-http-request-crash/basically-artistic-mole
branch
from
6296fba to
0c5c43d
Compare
hc-github-team-secure-boundary
deleted the
backport/jbrandhorst-fix-startup-http-request-crash/basically-artistic-mole
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #5304 to be assessed for backporting due to the inclusion of the label backport/0.18.x.
The below text is copied from the body of the original PR.
Don't error in ReleaseGate if the context used for the original event has been cancelled. Any error in ReleaseGate causes the controller to terminate its startup. If a user was trying to send a request to the Boundary controller as it started up, the context tied to the request would be reused to attempt logging the observation associated with the request after the logging gate was released. This would always fail, as the context associated with the request was canceled.
We now use a new context timeout for events logged after the release gate is released, if the original context was canceled.
Fixes ICU-15809
Overview of commits