Update release dir owner group #5299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old group only contains a service account. I updated it to the self managed release engineering group instead.
johanbrandhorst
commented
Dec 3, 2024
Merged
moduli
reviewed
Dec 3, 2024
CODEOWNERS
Outdated
Comment on lines
7
to
8
| /.release/ @hashicorp/team-selfmanaged-releng | ||
| /.github/workflows/build.yml @hashicorp/team-selfmanaged-releng |
There was a problem hiding this comment.
Should we just remove this? It looks like releng removed themselves about a year ago?
See #4057
There was a problem hiding this comment.
Sure, sounds good
Actually lets just remove this group, as per their justification in #4057
moduli
approved these changes
Dec 3, 2024
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old group only contains a service account. I removed this code owner to unblock us.