api: remove deprecated grant_scope_id field #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
website
core/iam
api
core/gen
core
core/proto
api/roles
core/daemon
labels
johanbrandhorst
force-pushed
the
jbrandhorst-remove-deprecated-grant-scope-id-parameter
branch
from
f7f5797 to
cef89e9
Compare
johanbrandhorst
commented
Jun 7, 2024
| default: | ||
| c.UI.Error("-grant-scope-id cannot be specified multiple times when using the deprecated create/update grant_scope_id mechanism") | ||
| return false | ||
| } |
There was a problem hiding this comment.
Sanity check: we're ok to remove this now, right? This flag isn't supported for create and update anymore.
johanbrandhorst
force-pushed
the
jbrandhorst-remove-deprecated-grant-scope-id-parameter
branch
2 times, most recently
from
bf08724 to
84f3b14
Compare
The grant_scope_id field was deprecated in 0.15.0, so we can remove it for 0.17.0.
johanbrandhorst
force-pushed
the
jbrandhorst-remove-deprecated-grant-scope-id-parameter
branch
from
84f3b14 to
ef08667
Compare
|
We may separately want to make a change to the boundary terraform provider, but I don't know if we have the same compatibility promise for that. CC @louisruch |
jefferai
force-pushed
the
jbrandhorst-remove-deprecated-grant-scope-id-parameter
branch
from
3a879b5 to
6742c34
Compare
jefferai
approved these changes
Jun 17, 2024
johanbrandhorst
deleted the
jbrandhorst-remove-deprecated-grant-scope-id-parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
grant_scope_idfield was deprecated in 0.15.0, so we can remove it for 0.17.0.