fix (plugins/gcpkms): update dep to fix issue with using gcp kms #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the go-kms-wrapping/extras/kms has been fixed to allow adding external key without a key id. See: hashicorp/go-kms-wrapping#214 for more information on the fix.
The underlying kms no longer requires KeyId() to add an external wrapper
johanbrandhorst
approved these changes
Nov 24, 2023
jimlambrt
added a commit
that referenced
this pull request
Nov 25, 2023
(cherry picked from commit 1872972)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the go-kms-wrapping/extras/kms has been fixed to allow adding external key without a key id.
See: hashicorp/go-kms-wrapping#214 for more information on the fix.
I have tested this fix by hand locally with a GCP KMS key.