-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated option application-credential-source #3728
Conversation
1d6e7a6
to
4535efe
Compare
4535efe
to
5e58565
Compare
internal/proto/controller/api/resources/targets/v1/target.proto
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback on moving the reserved deprecated fields, other than that:
- You should just confirm there are no enterprise
ssh
specific tests that will fail whenApplication credentials are removed
- Add a changelog that this was removed
I didn't check ent, so I'll look there to make sure. I did find a scenario in local env and a tf doc that had it. iirc everywhere else already had it listed as deprecated. I'll double check to make sure the docs say it's been removed if it only says deprecated |
ec1103c
to
2418d99
Compare
2418d99
to
ac06930
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great thanks!
ac06930
to
9d45a66
Compare
No description provided.