Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated option application-credential-source #3728

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

kheina
Copy link
Collaborator

@kheina kheina commented Sep 14, 2023

No description provided.

Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback on moving the reserved deprecated fields, other than that:

  • You should just confirm there are no enterprise ssh specific tests that will fail when Application credentials are removed
  • Add a changelog that this was removed

@kheina
Copy link
Collaborator Author

kheina commented Sep 19, 2023

Some minor feedback on moving the reserved deprecated fields, other than that:

* You should just confirm there are no enterprise `ssh` specific tests that will fail when `Application credentials are removed`

* Add a changelog that this was removed

I didn't check ent, so I'll look there to make sure. I did find a scenario in local env and a tf doc that had it. iirc everywhere else already had it listed as deprecated. I'll double check to make sure the docs say it's been removed if it only says deprecated

Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thanks!

@kheina kheina force-pushed the dmiu_remove-deprecated-app-cred-source branch from ac06930 to 9d45a66 Compare September 22, 2023 18:51
@kheina kheina merged commit a7c1876 into main Sep 22, 2023
@kheina kheina deleted the dmiu_remove-deprecated-app-cred-source branch September 22, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants