Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (ldap): support only updating the bind-dn and/or bind-password #3511

Merged
merged 4 commits into from
Jul 27, 2023
Merged

fix (ldap): support only updating the bind-dn and/or bind-password #3511

merged 4 commits into from
Jul 27, 2023

Conversation

jimlambrt
Copy link
Collaborator

No description provided.

@jimlambrt jimlambrt added this to the deferred milestone Jul 27, 2023
johanbrandhorst
johanbrandhorst approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something something overeager validation 😂

@jimlambrt
Copy link
Collaborator Author

@johanbrandhorst at least the validation was consistently incorrect at several layers.

@gsusmi gsusmi requested a review from lisbet-alvarez July 27, 2023 18:44
@psekar psekar modified the milestones: deferred, 0.13.x, 0.14.0 Jul 27, 2023
@jimlambrt jimlambrt merged commit f8ea8c9 into main Jul 27, 2023
@jimlambrt jimlambrt deleted the jimlambrt-ldap-update-only-bind-dn-and-bind-pass branch July 27, 2023 19:41
mikemountain pushed a commit that referenced this pull request Aug 3, 2023
@jimlambrt @mikemountain
fix (ldap): support only updating the bind-dn and/or bind-password (#…
99b3442 
…3511)

* fix (ldap): support only updating the bind-dn and/or bind-password

* chore: changelog entry for PR #3511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

@ajayreshc ajayreshc Awaiting requested review from ajayreshc

@lisbet-alvarez lisbet-alvarez Awaiting requested review from lisbet-alvarez

Assignees
No one assigned
Labels
core/auth core/daemon core
Projects
None yet
Milestone
0.14.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jimlambrt @johanbrandhorst @psekar