feature (auth): required schema changes for auth ldap method #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaffney
requested changes
Dec 2, 2022
mgaffney
requested changes
Dec 7, 2022
| unique(auth_method_id, public_id) | ||
| ); | ||
|
|
||
| create trigger insert_auth_account_subtype before insert on auth_ldap_account |
There was a problem hiding this comment.
Do we need update and delete triggers for auth_account_subtype?
There was a problem hiding this comment.
we definitely need a delete trigger. I don't believe we need an update trigger for the sub_type
jimlambrt
force-pushed
the
jimlambrt-ldap-schema
branch
from
929167a to
e77b3d9
Compare
mgaffney
requested changes
Dec 9, 2022
mgaffney
approved these changes
Dec 9, 2022
jimlambrt
added a commit
that referenced
this pull request
Dec 13, 2022
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Jan 3, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Jan 5, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Jan 7, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Jan 15, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Jan 19, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Jan 23, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Feb 1, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Feb 6, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Feb 8, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Feb 14, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Feb 15, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Feb 22, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Mar 1, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Mar 2, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Mar 3, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Mar 15, 2023
chore (auth/ldap): move schema changes to next avail migration number
jimlambrt
added a commit
that referenced
this pull request
Mar 15, 2023
…nts and managed groups (#2912) * feature (auth): required schema changes for auth ldap method (#2669) chore (auth/ldap): move schema changes to next avail migration number * feature (auth/ldap): define AuthMethod and all its value objects (#2703) * feature (auth/ldap): storage protos * feature (auth/ldap): define AuthMethod and all its value objects * feature (auth/ldap): add repo and reading an auth method (#2718) * feature (auth/ldap): add Repository.CreateAuthMethod(...) and Repository.DeleteAuthMethod(...) (#2724) * feature (auth/ldap): add Repository.UpdateAuthMethod(...) (#2739) * feature (auth/ldap): add Account * feature (auth/ldap): add AuthMethod.EnableGroups * fix (auth/ldap): refactor AuthMethod.oplog to enforce proper constraints * feature (auth/ldap): add Account repo functions * refactor (auth/ldap): remove entry attributes from account Realized the entry attributes could have absolutely anything in them (including binary data) and since we absolutely don't have to have them there's just no reason to take on the risk. * feature (auth/ldap): add AuthMethod.UseTokenGroups * feature (auth/ldap): add Authenticate(...) * refactor (auth/ldap): ensure options take a context as the 1st parameter * feature (auth/ldap): add Account attribute maps * chore (auth/ldap): make fmt deltas * feature (auth/ldap): add managed groups (#2760) * tests (auth/ldap): add missing unit test to Repository.DeleteAccount(...) Add bits to test the delete operation when you're not able to generate oplog metadata * feature (auth/ldap): add managed groups fixup! feature (auth/ldap): add managed groups (#2760) * feature (auth/ldap): service proto definition (#2761) * feature (handlers/authmethods): add handlers for ldap auth method operations (#2794) * feature (auth/ldap): add Account attribute maps * chore (auth/ldap): update cap/ldap to latest version * feature (auth/ldap): add ldap api generation definitions * feature (authmethods): add ldap repo NewService(...) * feature (authmethods/ldap): add proper mask_mapping to protobufs * feature (authmethods): add support to get an ldap auth method * refactor (auth/ldap): export TestGenerateCA(...) * feature (authmethods): add support to create an ldap auth method * feature (authmethods): add support to delete an ldap auth method * feature (authmethods): add support to list ldap auth methods * refactor (auth/ldap): make urls optional for NewAuthMethod(...) * refactor (auth/ldap): export ldap.TestInvalidPem * chore: make fmt changes * fix (auth/ldap): properly handle group search config Add constraints and tests to ensure when an ldap AuthMethod.EnableGroups is true, and UseTokenGroups is false; that there's a GroupDn configured for finding a user's associated groups * feature (authmethods): add support to update an ldap auth methods * chore (db/ldap): tmp mv migrations so there's no conflict with ongoing work * feature (verifier): add ldap auth method to verifier bits * fix (controller): prevent panic when controller stops when there's no listener * feature (authmethods): add support to authenticate via ldap auth methods * chore (migrations): fix whitespace in stmt * chore: fmt fixup * tests (auth/ldap): invalid err msg * feature (cli/authmethods): add support for ldap auth-methods CRUD and authenticate (#2810) * feature (authmethods): add CLI support for ldap auth methods CRUD * tests (api/auth): ldap auth method classification tests * feature (authmethods): add CLI support for ldap auth authenticate * feature (auth/ldap): set request timeouts for ldap server connections * feature (handlers/authmethods): handle u_anon listing properly. * feature (account/handers): ldap account and managed group CRUDL APIs (#2852) * feature (auth/ldap) add repository Listing of ManagedGroupMemberAccount * feature (controller/handlers): add ldapRepoFn to accounts service * feature (auth/ldap) register ldap managed group subtype * feature (account/handlers): ldap account CRUDL APIs * feature (controller/handlers): add ldapRepo to managed groups service * feature (account/handlers): ldap managed group CRUDL APIs * docs (domain): add LDAP accounts, auth-methods and managed groups (#2857) * feature (ldap/cli) add ldap accounts and managed groups CRUDL commands (#2856) * fix (handlers/authmethods): fix ldap authorized actions (#2892) * feature (cli/ldap/authenticate): use primary auth method if none is provided (#2890) * fix (auth/ldap): support setting the state attribute * feature (cli/ldap/authenticate): use primary auth method if none is provided * feature (wh/ldap) add tests for new ldap auth method and accounts (#2919) * refactor (migrations/ldap): mv to correct directory * chore: add copyright headers * fix (api/authmethods/ldap): renumber new LdapAuthMethodAttributes field * fix (auth/ldap): allow the auth method state to be updated (#2951) * chore: update sdk and api versions for llb - this is tmp until merging * tests (managed groups): add required errContains for new test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.