Allow descriptions to contain newlines and other whitespace #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Thanks @irenarindos |
irenarindos
changed the title
kheina
force-pushed
the
irindos-allow-whitespace-descriptions
branch
2 times, most recently
from
521bf33 to
52b4986
Compare
louisruch
approved these changes
May 14, 2024
kheina
force-pushed
the
irindos-allow-whitespace-descriptions
branch
from
52b4986 to
c7dad95
Compare
odd, I rebased again and added a changelog entry, lets see if the new commit has the same issue |
louisruch
requested changes
May 22, 2024
CHANGELOG.md
Outdated
| @@ -46,6 +46,8 @@ Canonical reference for changes, improvements, and bugfixes for Boundary. | |||
| ([PR](https://github.com/hashicorp/boundary-ui/pull/2237)) | |||
| * ui: Add UI support for MinIO (Enterprise and HCP Boundary only) | |||
| ([PR](https://github.com/hashicorp/boundary-ui/pull/2248)) | |||
| * Allow descriptions to contain newlines and other whitespace | |||
There was a problem hiding this comment.
This should be moved up to the Next section
There was a problem hiding this comment.
my eyes glazed over and I just added it to the first new and improved section I saw, my bad. fixed
kheina
force-pushed
the
irindos-allow-whitespace-descriptions
branch
from
c7dad95 to
bbc915e
Compare
AdamBouhmad
approved these changes
May 24, 2024
kheina
force-pushed
the
irindos-allow-whitespace-descriptions
branch
from
bbc915e to
7c7233d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.