-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grant parsing fuzz test #2534
Conversation
b7194aa
to
d17aa9d
Compare
Fuzzing did discover a fun one: |
Correct! This is allowed! |
Interesting! The error happened because this input creates a canonical string of |
I removed the "fix" for |
Yes, I think in general any trailing comma on a string should be stripped for parsing and for the canonical representation |
Meant to follow up on this: yes, |
OK so it sounds like the only real change here (accepting |
I ran this for a few minutes and it didn't discover anything catastrophic.
This is the same behavior as output_fields=,
d91348c
to
21dc028
Compare
…handling no fields
Adds fuzz tests for the grant parser. Running this I found two issues:
output_fields=,
was allowed whileoutput_fields=
was not. Now the latter is allowed and the former is equal to the latter.