-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add controller-led worker auth flow #2413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
api
core
core/daemon
core/db
core/gen
core/perms
core/proto
core/server
core/sql
core/types
labels
Aug 31, 2022
jefferai
force-pushed
the
jefferai-server-led-workers
branch
from
August 31, 2022 03:45
03e409d
to
bb37fdf
Compare
jefferai
force-pushed
the
jefferai-server-led-workers
branch
from
August 31, 2022 03:47
bb37fdf
to
0d9a1ee
Compare
jefferai
force-pushed
the
jefferai-server-led-workers
branch
from
August 31, 2022 04:16
0d9a1ee
to
61acf83
Compare
jefferai
force-pushed
the
jefferai-server-led-workers
branch
from
August 31, 2022 04:20
61acf83
to
df06b08
Compare
This adds an action to the API that allows pulling out an activation token that can be given to a worker in its config (directly or via env or file). The worker can pass this along with its normal request in place of its normal nonce and the server will automatically accept it.
jefferai
force-pushed
the
jefferai-server-led-workers
branch
from
August 31, 2022 05:07
df06b08
to
575390d
Compare
irenarindos
requested changes
Aug 31, 2022
internal/db/schema/migrations/oss/postgres/48/01_worker_auth_activation_token.up.sql
Outdated
Show resolved
Hide resolved
…ctivation_token.up.sql Co-authored-by: Irena Rindos <[email protected]>
jefferai
force-pushed
the
jefferai-server-led-workers
branch
from
August 31, 2022 18:43
9a2187d
to
acff73c
Compare
irenarindos
reviewed
Aug 31, 2022
irenarindos
reviewed
Aug 31, 2022
Co-authored-by: Irena Rindos <[email protected]>
irenarindos
approved these changes
Aug 31, 2022
talanknight
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just had a few comments that might be helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes advantage of the improvements in hashicorp/nodeenrollment#30 to allow pulling an activation token from a controller and submitting it to a worker via config.