Fix error validation code in attr parsing #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
force-pushed
the
jefferai-fix-attr-parsing
branch
from
f114265 to
3fd828e
Compare
For a flag type used for attributes/secrets, values have always been able to be used with env:// or file:// format, but the error check to see whether the value was successfully parsed was doing a simple string equality rather than `errors.Is`. As a result a value containing a colon would trip up this check and cause an error, rather than allowing it to be used as a bare value.
jefferai
force-pushed
the
jefferai-fix-attr-parsing
branch
from
3fd828e to
1a10e66
Compare
jefferai
added a commit
that referenced
this pull request
Aug 11, 2022
For a flag type used for attributes/secrets, values have always been able to be used with env:// or file:// format, but the error check to see whether the value was successfully parsed was doing a simple string equality rather than `errors.Is`. As a result a value containing a colon would trip up this check and cause an error, rather than allowing it to be used as a bare value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a flag type used for attributes/secrets, values have always been
able to be used with env:// or file:// format, but the error check to
see whether the value was successfully parsed was doing a simple string
equality rather than
errors.Is. As a result a value containing a colonwould trip up this check and cause an error, rather than allowing it to
be used as a bare value.
Fixes ICU-5629