Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsepath logic to password in various places #2325

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

jefferai
Copy link
Member

@jefferai jefferai commented Aug 5, 2022

  • Account password create/set/change
  • Authenticate

Also fixes a bug where confirmation on a change-password call would run
for the current password instead of the new one.

@jefferai jefferai added this to the 0.9.2 milestone Aug 5, 2022
@jefferai jefferai requested a review from louisruch August 5, 2022 16:04
@github-actions github-actions bot added the core label Aug 5, 2022
* Account password create/set/change
* Authenticate

Also fixes a bug where confirmation on a change-password call would run
for the current password instead of the new one.
@jefferai jefferai force-pushed the jefferai-password-parse-path branch from 0a4eee0 to 24c956a Compare August 5, 2022 16:08
@jefferai jefferai changed the title Add parsepath logic to password in various places: Add parsepath logic to password in various places Aug 5, 2022
internal/cmd/commands/accountscmd/funcs.go Outdated Show resolved Hide resolved
internal/cmd/commands/accountscmd/funcs.go Outdated Show resolved Hide resolved
internal/cmd/commands/accountscmd/funcs.go Outdated Show resolved Hide resolved
internal/cmd/commands/accountscmd/password_funcs.go Outdated Show resolved Hide resolved
internal/cmd/commands/authenticate/password.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the fmt comment but otherwise LGTM

@jefferai jefferai merged commit 26ffa70 into main Aug 5, 2022
@jefferai jefferai deleted the jefferai-password-parse-path branch August 5, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants