Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workers): Add ability to read and reinitialize cert authority #2312

Merged
merged 3 commits into from
Aug 18, 2022
Merged

feat(workers): Add ability to read and reinitialize cert authority #2312

merged 3 commits into from
Aug 18, 2022

Conversation

irenarindos
Copy link
Collaborator

@irenarindos irenarindos commented Aug 2, 2022 •
edited
Loading

Addition of domain function ReinitializeRoots
API implementation of ReinitializeCertificateAuthority and ListCertificateAuthority

@irenarindos irenarindos changed the title feat(workers): Add ability to list and reinit cert authority feat(workers): Add ability to read and reinitialize cert authority Aug 5, 2022
jefferai
jefferai requested changes Aug 10, 2022
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments -- this mostly looks great, just some inconsistencies to clear up and some cases where I think it could be simplified.

@irenarindos irenarindos requested a review from jefferai August 11, 2022 16:03
@irenarindos irenarindos force-pushed the irindos-reinit-root-certs branch from 26935cc to a214633 Compare August 16, 2022 15:32
@irenarindos irenarindos force-pushed the irindos-reinit-root-certs branch from c928370 to 61a422a Compare August 16, 2022 18:12
@irenarindos irenarindos merged commit 8e82350 into llb-byow-ga Aug 18, 2022
@irenarindos irenarindos deleted the irindos-reinit-root-certs branch August 18, 2022 12:42
@irenarindos irenarindos added this to the 0.10.3 milestone Aug 25, 2022
@sswati0 sswati0 modified the milestones: 0.10.4, 0.11.0 Sep 2, 2022
irenarindos added a commit that referenced this pull request Sep 8, 2022
@irenarindos
feat(workers): Add ability to read and reinitialize cert authority (#…
7c5577a 
…2312)

* feat(workers): Add ability to list and reinit cert authority
irenarindos added a commit that referenced this pull request Sep 8, 2022
@irenarindos
Merge BYOW GA branch to main (#2398)
18dff62 
* feat(workers): Add ability to read and reinitialize cert authority (#2312)

* feat(workers): Return Release Version on worker list and read (#2377)

* feat(cli): Read and reinitialize worker certificate authority (#2387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

@jimlambrt jimlambrt Awaiting requested review from jimlambrt

@A-440Hz A-440Hz Awaiting requested review from A-440Hz

Assignees
No one assigned
Labels
core/daemon core/gen core/perms core/proto core/server core/types core
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@irenarindos @jefferai @sswati0