Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate plugin host/set/catalog prefixes to typed #2256

Merged
merged 4 commits into from
Jul 15, 2022
Merged

Migrate plugin host/set/catalog prefixes to typed #2256

merged 4 commits into from
Jul 15, 2022

Conversation

jefferai
Copy link
Member

No description provided.

@jefferai jefferai force-pushed the jefferai-plugin-host-typed-prefixes branch from 5d6232f to 0d3ea1e Compare July 13, 2022 21:24
@jefferai jefferai added this to the 0.9.2 milestone Jul 13, 2022
@jefferai jefferai force-pushed the jefferai-plugin-host-typed-prefixes branch from 0d3ea1e to d0cd2e3 Compare July 13, 2022 21:58
johanbrandhorst
johanbrandhorst previously approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited

@jefferai jefferai requested a review from johanbrandhorst July 14, 2022 00:25
@jefferai jefferai requested a review from louisruch July 14, 2022 15:43
@jefferai
Copy link
Member Author

@louisruch @johanbrandhorst After discussion with @louisruch we realized some more changes needed to be made. I've also simplified the logic -- I had added to logic that was there in target_service.go that already was doing the wrong thing -- thanks for the pointer on that @johanbrandhorst .

louisruch
louisruch approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefferai jefferai merged commit 8c56a56 into main Jul 15, 2022
@jefferai jefferai deleted the jefferai-plugin-host-typed-prefixes branch July 15, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisruch louisruch louisruch approved these changes

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

@talanknight talanknight Awaiting requested review from talanknight

Assignees
No one assigned
Labels
core/daemon core/host core
Projects
None yet
Milestone
0.9.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jefferai @johanbrandhorst @louisruch