fix (kms): properly reconcile DEKs for existing scopes #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When new DEKs are added to boundary we need to ensure that the keys for existing scopes are reconciled. This fix should address: #1856
johanbrandhorst
previously approved these changes
Apr 6, 2022
johanbrandhorst
approved these changes
Apr 6, 2022
tmessi
approved these changes
Apr 7, 2022
jefferai
reviewed
Apr 12, 2022
| // | ||
| // NOTE: don't add an audit key here since it can only be created in | ||
| // the global scope. | ||
| KeyPurposeOidc, |
There was a problem hiding this comment.
Are we already creating OIDC DEKs for non-global/org scopes? If not we may want a check here since this will be called with all scopes from the controller New function.
There was a problem hiding this comment.
We are calling kms.CreateKeysTx(...) every time we create a new scope.
jefferai
reviewed
Apr 12, 2022
jefferai
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new DEKs are added to boundary we need to ensure that the keys
for existing scopes are reconciled.
This fix should address:
#1856