bug(plugin): Fix incorrect use of WithIpAddrs in Repository.Endpoints #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justenwalker
force-pushed
the
justen/fix-1848
branch
from
b165dbf to
eb912ec
Compare
talanknight
suggested changes
Feb 9, 2022
When creating the options for the preferencer, this used WithIpAddrs for both the host addresses and also DNS names. This causes errors when a host contains DNS names that are not IP addresses (ie: whenever dns names are present). This change will: - Replace WithIpAddrs with WithDNSNames option for DNS Names when constructing options for the preferencer. - Add a test which includes a DNS name to prevent regressions Fixes hashicorp#1848
justenwalker
force-pushed
the
justen/fix-1848
branch
from
eb912ec to
898a428
Compare
I've applied your suggestions to this PR. Please have another look and let me know if there is anything else you think I should do. |
talanknight
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the options for the preferencer, this used WithIpAddrs for both the host addresses and also DNS names. This causes errors when a host contains DNS names that are not IP addresses (ie: whenever dns names are present).
This change will:
Fixes #1848