feat(config): Add env and file support to Worker Tags #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmessi
requested changes
Dec 3, 2021
|
e387b1b adds support for setting the tag keys in the HCL config, but then getting the values from env or file, so we support both block-level abstraction as well as per key abstraction. |
tmessi
reviewed
Dec 6, 2021
|
13fb337, 942c534, 26c7128 and e51967d add some more tests for completeness as well as docs changes to reflect the new functionality. |
tmessi
reviewed
Dec 7, 2021
hugoghx
changed the title
hugoghx
changed the title
hugoghx
changed the title
tmessi
previously approved these changes
Dec 7, 2021
This feature allows the user to set the `tags` field to a string that points to either an environment variable or file. We then dynamically pull out the value and parse it into the config. This can also be done at the keys level, where you set your keys directly in Boundary's config file, but point the values to env/file.
hugoghx
force-pushed
the
hugoamvieira-env-file-workertags
branch
from
f8de0f3 to
1576af7
Compare
tmessi
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this by taking a look at the HCL before the actual tag parsing and resolving the string to whatever value exists underneath, and then pass it on to the actual parsing.
This ensures that previous functionality is not affected.