Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add client ip to inbound request information #1678

Merged
merged 11 commits into from
Dec 10, 2021
Merged

feature: Add client ip to inbound request information #1678

merged 11 commits into from
Dec 10, 2021

Conversation

jimlambrt
Copy link
Collaborator

No description provided.

@jimlambrt jimlambrt force-pushed the jimlambrt-audit-client-ip branch from f8530a0 to 3d11edf Compare November 7, 2021 11:37
@jimlambrt jimlambrt force-pushed the jimlambrt-audit-client-ip branch from 3d11edf to 9d3211d Compare November 7, 2021 11:40
@jimlambrt jimlambrt force-pushed the jimlambrt-audit-client-ip branch from 9d3211d to b784169 Compare November 8, 2021 11:59
@jimlambrt jimlambrt force-pushed the jimlambrt-audit-client-ip branch from ca51c88 to 0a881de Compare November 8, 2021 13:28
@jimlambrt jimlambrt mentioned this pull request Nov 8, 2021
Closed
louisruch
louisruch reviewed Nov 12, 2021
View reviewed changes
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run make fmt also I have one question on logic to get client IP, haven't used the headers too much in the past so going on names to what I think is a potentially better ordering.

internal/servers/common/client_ip.go Outdated Show resolved Hide resolved
internal/servers/controller/listeners.go Outdated Show resolved Hide resolved
@jimlambrt jimlambrt force-pushed the jimlambrt-audit-client-ip branch from 593bbb8 to 5cdad32 Compare November 14, 2021 19:17
@jimlambrt jimlambrt requested a review from louisruch November 16, 2021 11:15
@jimlambrt jimlambrt force-pushed the jimlambrt-audit-client-ip branch from 5cdad32 to 2677f8c Compare November 16, 2021 12:36
louisruch
louisruch previously approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimlambrt
feature: Add client ip to inbound request information
31a6115
@jimlambrt
chore: Update go-secure-stdlib deps to temp use a branch
662b1a0 
The jimlambrt-forwarded-for branch contains some required features
required by this work.  Once PR #17 in that repo is merged, then
we can just pull the latest from main
@jimlambrt
feature (client ip): Integrate listenerutil.TrustedFromXForwardedFor(..)
ebc0fde 
listenerutil.TrustedFromXForwardedFor provides a capability to use
XForwardedFor* listener config settings to determine how/if
X-Forwarded-For are trusted/allowed for an inbound request
@jimlambrt
refactor: Updated handling of x-forwarded-for headers
55db102 
Updated go-secure-stdlib/listenerutil.TrustedFromXForwardedFor which
changed how headers are trusted when determining the client ip.

We also deferred any support for the real ip header to future work.
@jimlambrt jimlambrt force-pushed the jimlambrt-audit-client-ip branch from 2677f8c to 55db102 Compare November 30, 2021 00:41
@jimlambrt jimlambrt mentioned this pull request Nov 30, 2021
Merged
louisruch
louisruch previously approved these changes Dec 1, 2021
View reviewed changes
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment around the changelog entry

CHANGELOG.md Outdated Show resolved Hide resolved
@jimlambrt jimlambrt requested a review from louisruch December 1, 2021 18:56
louisruch
louisruch reviewed Dec 2, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jimlambrt jimlambrt requested a review from louisruch December 2, 2021 11:17
jefferai
jefferai previously approved these changes Dec 2, 2021
View reviewed changes
louisruch
louisruch previously approved these changes Dec 3, 2021
View reviewed changes
jefferai
jefferai previously approved these changes Dec 9, 2021
View reviewed changes
@jimlambrt jimlambrt dismissed stale reviews from jefferai and louisruch via 42db309 December 10, 2021 00:23
@jimlambrt
Merge branch 'main' into jimlambrt-audit-client-ip
67444d8
@jimlambrt
refactor: Post merge from main changes required.
175aba5 
Need to update TestConnection(...) additions to use the new signature
and update the CHANGELOG entry.
@jimlambrt jimlambrt merged commit baa1d88 into main Dec 10, 2021
@jimlambrt jimlambrt deleted the jimlambrt-audit-client-ip branch December 10, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisruch louisruch louisruch left review comments

@jefferai jefferai jefferai left review comments

Assignees
No one assigned
Labels
core/db core/gen core/proto core/servers core/session core/sql core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimlambrt @jefferai @louisruch