Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support new event formats of: hclog-text and hclog-json #1440

Merged
merged 16 commits into from
Aug 3, 2021
Merged

support new event formats of: hclog-text and hclog-json #1440

merged 16 commits into from
Aug 3, 2021

Conversation

jimlambrt
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the core label Aug 2, 2021
jefferai
jefferai previously approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10, would observe again

schristoff
schristoff approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment but 🤙

@jimlambrt jimlambrt merged commit 3a3f956 into main Aug 3, 2021
@jimlambrt jimlambrt deleted the jimlambrt-event-hclog-formatter branch August 3, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

@jefferai jefferai jefferai approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimlambrt @jefferai @schristoff