-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update primary error functions to take a context, deprecate old functions #1358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I have one comment about Wrap calling EDeprecated
The only other general comment I would have is that all the test files only test EDeprecated, perhaps if we do add an unexported e that could be used instead...I will look again Monday great work so far!
+1 on this idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! I just have a few comments/suggestions.
There are a large number of cases in this PR where there is a context in the function but EDeprecated is used instead of just using the context passed in. It would be good to go through and use the context when available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The WithoutEvent
and using context.Todo
works well and neatly resolves my concerns around tying us down to never being able to deprecate these functions. ty
No description provided.