Allow dash in account name

Update changelog
hashicorp · Dec 1, 2020 · 1920d77 · 1920d77
1 parent af2d9df
commit 1920d77
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,11 +4,17 @@ Canonical reference for changes, improvements, and bugfixes for Boundary.
 
 ## vNext
 
+### New and Improved
+
+* controller: Relax account login name constraints to allow dash as valid character 
+  ([Issue](https://github.com/hashicorp/boundary/issues/759))
+  ([PR](https://github.com/hashicorp/boundary/pull/806))
+
 ### Bug Fixes
 
 * cli: Ensure errors print to stderr when token is not found
   ([Issue](https://github.com/hashicorp/boundary/issues/791))
-  ([PR](https://github.com/hashicorp/boundary/pull/799)]
+  ([PR](https://github.com/hashicorp/boundary/pull/799))
 
 ## v0.1.2
 

diff --git a/internal/auth/password/repository_account.go b/internal/auth/password/repository_account.go
@@ -190,7 +190,7 @@ func (r *Repository) DeleteAccount(ctx context.Context, scopeId, withPublicId st
 	return rowsDeleted, nil
 }
 
-var reInvalidLoginName = regexp.MustCompile("[^a-z0-9.]")
+var reInvalidLoginName = regexp.MustCompile("[^a-z0-9.-]")
 
 func validLoginName(u string) bool {
 	if u == "" {

diff --git a/internal/auth/password/repository_account_test.go b/internal/auth/password/repository_account_test.go
@@ -27,6 +27,8 @@ func TestCheckLoginName(t *testing.T) {
 		{"contains spaces", false},
 		{"NotLowerCase", false},
 		{"valid.loginname", true},
+		{"valid-loginname", true},
+		{"validloginname", true},
 	}
 	for _, tt := range tests {
 		tt := tt