-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin UI filtering #2237
Merged
Merged
Admin UI filtering #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: 🎸 Initial setup of IndexedDB * fix: 🐛 Rethrow errors up from indexed db handler
* feat: 🎸 Add indexedDb parser ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12164 --------- Co-authored-by: Lisbet Alvarez <[email protected]>
* feat: 🎸 Add filtering/pagination for admin ui targets ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12193 * test: 💍 add acceptance test cases ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12193 * test: 💍 cleanup tests and add controller tests ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12193 --------- Co-authored-by: Lisbet Alvarez <[email protected]>
* feat: 🎸 add search & pagination for roles ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12590
* refactor: 💡 move model hook to groups/index ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 * feat: 🎸 add pagination to groups list view ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 * feat: 🎸 add searching to groups ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 * fix: 🐛 update scopeId to scope_id ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 * test: 💍 clean up test refactor ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 * refactor: 💡 update how groupsExisit is set ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 * refactor: 💡 update mirage config for groups ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 * test: 💍 fix failing groups create tests ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 * refactor: 💡 add groups mirage config back ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 * refactor: 💡 use translation string for Groups ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 * refactor: 💡 update how groups are queried ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 * Update ui/admin/tests/acceptance/groups/list-test.js Co-authored-by: Zhihe Li <[email protected]> * refactor: 💡 update groups translation to title_plural ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12591 --------- Co-authored-by: Zhihe Li <[email protected]>
* feat: 🎸 add pagination and filtering to sessions page ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 fix handling of null values in indexed-db-query ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 add method signatures where missing ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 address PR feedback ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * fix: 🐛 add override for table header color when sortable ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 remove poller and add manual refresh action ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 remove force_refresh from sessions route queries ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 add user getter to session model ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 remove logicalOperator value from queries ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 move action to controller from router ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 remove cleanValues from indexed-db-query ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 remove potential null values for user/target ids ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 add async/await back to cancelSession ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 update sessions route ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 use translation string for Sessions ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * test: 💍 fix controller test ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 add scope_id to filters for query ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 remove scope_id and recursive in sessions query ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587 * refactor: 💡 how user query to use global and org scope ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12587
* fix: 🐛 add parentScope.id to refresh action for sessions * refactor: 💡 remove scope_id from users and targets query
* feat: 🎸 add filtering & pagination support for credential-store ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12782 --------- Co-authored-by: Zhihe Li <[email protected]>
* feat: 🎸 Add searching for host catalogs ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12781
* refactor: 💡 update Dropdown component to have name & toggleText ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13336 * test: 💍 remove hds class selector ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13336
* refactor: 💡 add active sessions column to targets table ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13085 * test: 💍 add test case ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13085
* feat: 🎸 add filtering and pagination to scopes ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13302
* refactor: 💡 reduce network requests & call indexedDB directly ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13251
Added logic to make the list tokens stored in indexed DB more granular. I get a hash of the query parameters that will get sent to the controller and use that as the id for the token. This also means extra logic for when a token is invalid as we will need to delete all tokens of the same resource type.
…2224) * refactor: 💡 update query requests for resources in indexedDB ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13359
…nd targets (#2226) * refactor: 💡 hide active sessions filter if no list permissions ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13374 * test: 💍 add active sessions filter permissions test ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13374 * refactor: 💡 add permissions check for targets and users ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13374 * refactor: 💡 address PR feedback ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13374 * refactor: 💡 move user permission check to a helper func ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13374 * refactor: 💡 move permissions logic to user and target helper ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13374
* fix: 🐛 Fix tests broken by rebase onto main --------- Co-authored-by: cameronperera <[email protected]>
* test: 💍 fix failing tests ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13357 * feat: 🎸 add generic loading indicator for admin ui ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13357 * feat: 🎸 add custom loading logic for search and filtering ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13357 * chore: 🤖 fix lint error ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13357 * refactor: 💡 remove commented helper for sessions list ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13357 * style: 💄 update loading indicator margin to relative unit ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13357 * refactor: 💡 remove unneeded custom loading action ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13357
* feat: 🎸 add filtering & pagination to auth methods ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12592 --------- Co-authored-by: Zhihe Li <[email protected]> Co-authored-by: Cameron Perera <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cameronperera
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work team!
lisbet-alvarez
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the search and filtering work that has been previously approved.