fix: 🐛 Fix serializing client secrets in oidc auth methods #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dvonanderson
approved these changes
May 26, 2023
cameronperera
approved these changes
May 26, 2023
|
ty! |
ghost
suggested changes
May 26, 2023
My mistake, I wasn't aware |
DhariniJeeva
approved these changes
May 26, 2023
ZedLi
force-pushed
the
bugfix/fix-oidc-client-secret
branch
from
96006ac to
d3a2e43
Compare
ghost
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are currently serializing client secrets in the OIDC auth methods form even if they're null. Annotated it as a secret so it won't get serialized if it doesn't exist
See this thread for more details.